Skip to content

Add CSP nonce on inline script in storage-change-detection.html #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

Add CSP nonce on inline script in storage-change-detection.html #1388

merged 1 commit into from
Apr 30, 2021

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Apr 30, 2021

fixes #1387

jyn514
jyn514 approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once clippy has been appeased

@jyn514
Copy link
Member

jyn514 commented Apr 30, 2021 

 thread 'docbuilder::rustwide_builder::tests::test_build_crate' panicked at 'assertion failed: `(left == right)`
  left: `false`,
 right: `true`', src/docbuilder/rustwide_builder.rs:735:13

Same issue as before; unrelated to this change.

@jyn514 jyn514 merged commit 63fe23e into rust-lang:master Apr 30, 2021
@Nemo157 Nemo157 deleted the 1387 branch May 31, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detecting rusdoc theme change fails with CSP
2 participants
@Nemo157 @jyn514