CSS: Remove composes usage
#10874
Merged
CSS: Remove composes usage
#10874
+196
−427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-frontend 🐹
C-internal 🔧
Turbo87
force-pushed
the
composes
branch
2 times, most recently
from
cb0258d to
494f12e
Compare
|
looks like there are a bunch of CSS specificity issues that only show up when restarting the |
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
This prepares for the migration to ember-scoped-css, which does not support `composes`.
Turbo87
commented
Apr 10, 2025
Comment on lines
+58
to
+72
| // see https://github.com/salsify/ember-css-modules/blob/v2.0.1/docs/ORDERING.md | ||
| headerModules: [ | ||
| 'crates-io/styles/shared/a11y', | ||
| 'crates-io/styles/shared/buttons', | ||
| 'crates-io/styles/shared/forms', | ||
| 'crates-io/styles/shared/sort-by', | ||
| 'crates-io/styles/shared/typography', | ||
| 'crates-io/styles/application', | ||
| // for the `.load-more` class | ||
| 'crates-io/styles/dashboard', | ||
| // for the `.scopes-list` class | ||
| 'crates-io/styles/settings/tokens/new', | ||
| // for the `.box-link` class | ||
| 'crates-io/components/front-page-list/item', | ||
| ], |
There was a problem hiding this comment.
not a great long-term solution, but this solves the specificity issues. previously the composes declarations ensured the right order in the CSS file, but since we no longer use composes we need to explicitly declare it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/BlueCutOfficial/css-modules-to-scoped-css documents how to migrate from ember-css-modules to ember-scoped-css, which unlocks building the frontend application with https://vite.dev/ instead of webpack.
Unfortunately, ember-scoped-css does not support the
composesdeclaration from ember-css-modules though.This PR removes/replaces the 97 usages of
composesin our codebase. I'm not in love with the solution, but it seems good enough for now to unlock that migration mentioned above.