Switch repository layout to use a virtual manifest #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
workspace-changes
branch
from
c469254 to
e9de7ab
Compare
tgross35
force-pushed
the
workspace-changes
branch
from
e9de7ab to
b7c63f1
Compare
tgross35
force-pushed
the
workspace-changes
branch
3 times, most recently
from
9a42baa to
f8c56a2
Compare
tgross35
force-pushed
the
workspace-changes
branch
9 times, most recently
from
eaae536 to
d4f360e
Compare
tgross35
changed the title
tgross35
changed the title
tgross35
force-pushed
the
workspace-changes
branch
2 times, most recently
from
a6a5041 to
9a7e461
Compare
The current setup has the `Cargo.toml` for `compiler-builtins` at the repository root, which means all support crates and other files are located within the package root. This works for now but is not the cleanest setup since files that should or shouldn't be included in the package need to be configured in `Cargo.toml`. If we eventually merge `libm` development into this repository, it would be nice to make this separation more straightforward. Begin cleaning things up by moving the crate source to a new `compiler-builtins` directory and adding a virtual manifest. For now the `libm` submodule is also moved, but in the future it can likely move back to the top level (ideally `compiler-builtins/src` would contain a symlink to `libm/src/math`, but unfortunately it seems like Cargo does not like something about the submodule + symlink combination).
tgross35
force-pushed
the
workspace-changes
branch
from
9a7e461 to
920e3d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup has the
Cargo.tomlforcompiler-builtinsat therepository root, which means all support crates and other files are
located within the package root. This works for now but is not the
cleanest setup since files that should or shouldn't be included in the
package need to be configured in
Cargo.toml. If we eventually mergelibmdevelopment into this repository, it would be nice to make thisseparation more straightforward.
Begin cleaning things up by moving the crate source to a new
compiler-builtinsdirectory and adding a virtual manifest. For now thelibmsubmodule is also moved, but in the future it can likely moveback to the top level (ideally
compiler-builtins/srcwould contain asymlink to
libm/src/math, but unfortunately it seems like Cargo doesnot like something about the submodule + symlink combination).