-
Notifications
You must be signed in to change notification settings - Fork 246
ci: Use nextest on PowerPC64LE and s390x #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Our scripts use nextest if possible. This is skipped on the native ppc | ||
# and s390x runners since install-action doesn't support them. | ||
- uses: taiki-e/install-action@nextest | ||
if: "!(matrix.os == 'ubuntu-24.04-ppc64le' || matrix.os == 'ubuntu-24.04-s390x')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said in taiki-e/install-action#1056 (comment), it is actually probably better to use cache-cargo-install-action on these platforms.
That said, considering that it is almost always necessary to do that on these platforms, using cache-cargo-install-action is definitely better than install-action in terms of performance. (Eventually, the two may be merged, but there is no concrete plan yet: taiki-e/install-action#66)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only on ppc/s390x or on all platforms? I'm happy to use either, just would prefer if the same one could be used for all platforms rather than using the special case.
I could have switched to cache-cargo-install-action here, but the scripts have a fallback to cargo test
that worked fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cache-cargo-install-action is only efficient than install-action on platforms where pre-built binaries is not available, so if using only one of the two, install-action is better here (in this case, cache-cargo-install-action is only efficient for two jobs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This LGTM if there isn't any reason to hold off (given the draft status)
See taiki-e/install-action#1056 for the context.
Depend on taiki-e/install-action#1133.UPDATE: released