Skip to content

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 8, 2025

See taiki-e/install-action#1056 for the context.

Depend on taiki-e/install-action#1133. UPDATE: released

@taiki-e taiki-e changed the title [WIP] ci: Use nextest on PowerPC64LE and s390x ci: Use nextest on PowerPC64LE and s390x Sep 8, 2025
Comment on lines -135 to -138
# Our scripts use nextest if possible. This is skipped on the native ppc
# and s390x runners since install-action doesn't support them.
- uses: taiki-e/install-action@nextest
if: "!(matrix.os == 'ubuntu-24.04-ppc64le' || matrix.os == 'ubuntu-24.04-s390x')"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in taiki-e/install-action#1056 (comment), it is actually probably better to use cache-cargo-install-action on these platforms.

That said, considering that it is almost always necessary to do that on these platforms, using cache-cargo-install-action is definitely better than install-action in terms of performance. (Eventually, the two may be merged, but there is no concrete plan yet: taiki-e/install-action#66)

Copy link
Contributor

@tgross35 tgross35 Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only on ppc/s390x or on all platforms? I'm happy to use either, just would prefer if the same one could be used for all platforms rather than using the special case.

I could have switched to cache-cargo-install-action here, but the scripts have a fallback to cargo test that worked fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache-cargo-install-action is only efficient than install-action on platforms where pre-built binaries is not available, so if using only one of the two, install-action is better here (in this case, cache-cargo-install-action is only efficient for two jobs).

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This LGTM if there isn't any reason to hold off (given the draft status)

@taiki-e taiki-e marked this pull request as ready for review September 10, 2025 09:54
@tgross35 tgross35 merged commit 6ed20e6 into rust-lang:master Sep 10, 2025
38 checks passed
@taiki-e taiki-e deleted the ppc-z branch September 10, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants