Skip to content

Conversation

@Muscraft
Copy link
Member

@Muscraft Muscraft commented Oct 15, 2025

Over the past few months, I have noticed various PRs that were created to fix typos, and figured that it would be a good idea to add a non-blocking1 CI job that runs typos2 to hopefully catch typos before they are merged into the codebase. The configuration file for typos in this PR is meant to get the ball rolling and is by no means perfect.

Footnotes

  1. I chose to make this non-blocking, so any newly added corrections don't cause CI to fail.

  2. The workflow file for the job matches the one in annotate-snippets-rs

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) A-console-output Area: Terminal output, colors, progress bar, etc. A-documenting-cargo-itself Area: Cargo's documentation A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-layout Area: target output directory layout, naming, and organization A-manifest Area: Cargo.toml issues A-rebuild-detection Area: rebuild detection and fingerprinting A-testing-cargo-itself Area: cargo's tests A-timings Area: timings A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2025
- name: Checkout Actions Repository
uses: actions/checkout@v5
- name: Spell Check Repo
uses: crate-ci/typos@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to block CI?

If so, we have to do one of

  • change settings on the repo
  • put this in the main workflow and have Conclusion depend on it

(iiuc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should pin the job and have renovatebot update it

Copy link
Member

@weihanglo weihanglo Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it should be a non-blocking job first:

  • We don't know how reliable it is (e.g. how many false-positives it has)
  • We don't want to block the PR just because some new identifier needs to be added to the typo config

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like these are summarized as "we don't know how much of a pain this will be, are we sure we want to commit?".

However, we do have history for this

On the other hand, by not having it be blocking,

  • We might enable auto-merge and miss that typos has failed
  • We confuse contributors when with existing failures
  • We confuse contributors with whether they are accountable for it (the UI does not make it clear when jobs are non-blocking)

@Muscraft Muscraft force-pushed the add-typos branch 2 times, most recently from 5b2c0fd to bf11cab Compare October 16, 2025 01:21
@ehuss
Copy link
Contributor

ehuss commented Nov 11, 2025

@rustbot author

IIRC, this is waiting on:

  • Making it block on CI
  • I'd like to see some documentation in the contributor guide (or somewhere) to let a contributor know that this exists and how to run it locally (and maybe guidance on updating typos.toml? not sure if there is anything to write, though.)

@rustbot rustbot added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2025
@rustbot rustbot added A-dependency-resolution Area: dependency resolution and the resolver Command-package Command-vendor labels Nov 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@epage epage enabled auto-merge November 12, 2025 18:00
@epage epage added this pull request to the merge queue Nov 12, 2025
Merged via the queue into rust-lang:master with commit e2c8f3c Nov 12, 2025
28 checks passed
@Muscraft Muscraft deleted the add-typos branch November 12, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build-execution Area: anything dealing with executing the compiler A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) A-console-output Area: Terminal output, colors, progress bar, etc. A-dependency-resolution Area: dependency resolution and the resolver A-documenting-cargo-itself Area: Cargo's documentation A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-layout Area: target output directory layout, naming, and organization A-manifest Area: Cargo.toml issues A-rebuild-detection Area: rebuild detection and fingerprinting A-testing-cargo-itself Area: cargo's tests A-timings Area: timings A-workspaces Area: workspaces Command-package Command-vendor S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants