chore(deps): Depend on serde_core in cargo-platform
#15992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-cfg-expr
ehuss
reviewed
Sep 22, 2025
| [dependencies] | ||
| serde_core.workspace = true | ||
|
|
||
| [target.'cfg(any())'.dependencies] |
There was a problem hiding this comment.
What is the reason for this target table?
There was a problem hiding this comment.
It bumps the requirement of serde to the minimum required for serde_core. I don't think this is required, however other serde_core users add this cfg
There was a problem hiding this comment.
Can you please add a comment explaining that? My understanding is that if someone has a lockfile with a version of serde from before serde_core was added, serde will stay on the older version while cargo-platform will use serde_core and thus have the wrong definitions.
DaniPopes
force-pushed
the
serde_core
branch
from
0c9923f to
5542e96
Compare
`cargo-platform` does not make use of serde derive macros, thus it can depend on `serde_core` instead of `serde` to speed up users' compile times. See the documentation of [`serde_core`](https://docs.rs/serde_core) for more details.
DaniPopes
force-pushed
the
serde_core
branch
from
5542e96 to
cbebafb
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-platformdoes not make use of serde derive macros, thus it can depend onserde_coreinstead ofserdeto speed up users' compile times.See the documentation of
serde_corefor more details.