Skip to content

fix(shell): Switch to annotate snippets for notes #15945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix(shell): Switch to annotate snippets for notes #15945

merged 1 commit into from
Sep 26, 2025

Conversation

epage
Copy link
Contributor

@epage epage commented Sep 10, 2025

What does this PR try to resolve?

This is part of #15944

This was split out of #15917

How to test and review this PR?

@rustbot rustbot added A-console-output Area: Terminal output, colors, progress bar, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@epage epage marked this pull request as draft September 10, 2025 01:58
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2025
@epage epage changed the title fix(shell): Switch to annotate snippets for notes WIP: fix(shell): Switch to annotate snippets for notes Sep 10, 2025
@epage
Copy link
Contributor Author

epage commented Sep 10, 2025

Blocked on #15942, #15943

This was referenced Sep 10, 2025
Open
Draft
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Sep 12, 2025
@epage epage changed the title WIP: fix(shell): Switch to annotate snippets for notes fix(shell): Switch to annotate snippets for notes Sep 26, 2025
@epage epage marked this pull request as ready for review September 26, 2025 16:24
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2025
@epage
Copy link
Contributor Author

epage commented Sep 26, 2025

@rustbot ready

@epage epage removed the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Sep 26, 2025
weihanglo
weihanglo approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo weihanglo added this pull request to the merge queue Sep 26, 2025
Merged via the queue into rust-lang:master with commit ed2f8ef Sep 26, 2025
25 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2025
@epage epage deleted the annotate-note branch September 26, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-console-output Area: Terminal output, colors, progress bar, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epage @rustbot @weihanglo