-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Improved error message for versions prefixed with v
#15484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks nice.
Would you mind following the atomic commit pattern the contributor guide suggests? Which we add a new test first than captures the current behavior, followed by the next commit containing both the fix and test change. That makes the behavior change more prominent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is a way to reuse these logic, but given they are simple it is fine. Thank you!
What does this PR try to resolve?
CRATE[@<VER>]
or--version <VER>
starts with 'v' forinstall
,add
,yank
andupdate --precise <VER>
cargo yank
Fixes #12331
How should we test and review this PR?
Added tests for each subcommand