fix: ignore unrelated comments #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Feb 26, 2025
There was a problem hiding this comment.
I checked the code again and it seems like we didn't spam the repo with error comments anymore 😅 We would produce an error in the log though, and mainly we would spam GitHub, both of which is not needed, so this PR is still a nice improvement.
Thank you! Left a few nits.
|
Thanks! Please squash the changes and we're good to go. Looks like I'll also need to fix CI. |
Sakib25800
force-pushed
the
fix/prevent-spam-errors
branch
from
5ecb236 to
f8a9894
Compare
|
I think you'll need to repush the commit to retrigger CI on the fixed main branch. GH doesn't allow me to update the branch via GUI :( |
Sakib25800
force-pushed
the
fix/prevent-spam-errors
branch
from
f8a9894 to
3cd98c4
Compare
|
This is part of what using bors would have solved right? 😆 |
|
Well, unless we do #202, which would then wait for PR CI to be green :) Thanks! |
Kobzol
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124