Update README instructions for web browsers on Windows #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git Bash tries to open `http://.bookindex.html/` with the provided command. Quoting the path solved the problem. ```shell start firefox.exe ".\book\index.html" ``` Cmd and Powershell both work with or without quotes. Since `start` works in PowerShell, I removed Start-Process from the README to simplify it, but I've only tested on Windows 11. I don't know if start works everywhere, but I do have a Windows 10 machine I can check on if you like? Using Ubuntu in Windows Terminal (WSL) has the same problem as Git Bash if the path isn't quoted. It works when using a command like this (Windows version of Firefox): ```powershell.exe start firefox ".\book\index.html" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git Bash tries to open
http://.bookindex.html/with the provided command. Quoting the path solved the problem.shell start firefox.exe ".\book\index.html"Cmd and Powershell both work with or without quotes.
Since
startworks in PowerShell, I removed Start-Process from theREADME to simplify it, but I've only tested on Windows 11. I don't know
if start works everywhere, but I do have a Windows 10 machine I can
check on if you like?
Using Ubuntu in Windows Terminal (WSL) has the same problem as Git Bash
if the path isn't quoted. It works when using a command like this
(Windows version of Firefox):
powershell.exe start firefox ".\book\index.html"