Skip to content

Adapt to embedded-hal-1.0.0-alpha.2 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Adapt to embedded-hal-1.0.0-alpha.2 #48

wants to merge 2 commits into from

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Oct 30, 2020

Builds on and superseeds #43

@eldruin eldruin requested a review from a team as a code owner October 30, 2020 07:46
@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels Oct 30, 2020
@ryankurte ryankurte mentioned this pull request Nov 2, 2020
Closed
@ryankurte
Copy link
Contributor

I've created a v0.3.x branch for ongoing maintenance of these releases, happy to land this on master for alpha releases now @posborne ?

@ryankurte
Copy link
Contributor

@eldruin could you please update the changelog? then i can approve this / land #49 and ship an alpha ^_^

@eldruin eldruin force-pushed the embedded-hal-1.0.0-alpha.2 branch from ae020cf to a2a3bae Compare November 3, 2020 07:47
@eldruin
Copy link
Member Author

eldruin commented Nov 3, 2020

@ryankurte done, thanks!

ryankurte
ryankurte approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

bors r+

bors bot added a commit that referenced this pull request Nov 3, 2020
@bors @eldruin
Merge #48
5da85bb 
48: Adapt to embedded-hal-1.0.0-alpha.2 r=ryankurte a=eldruin

Builds on and superseeds #43 

Co-authored-by: Diego Barrios Romero <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 3, 2020

Timed out.

@eldruin eldruin mentioned this pull request Nov 4, 2020
Merged
@eldruin
Copy link
Member Author

eldruin commented Nov 4, 2020

Closing in favour of #50

@eldruin eldruin closed this Nov 4, 2020
bors bot added a commit that referenced this pull request Nov 5, 2020
@bors @eldruin
Merge #50
be456d2 
50: Embedded hal 1.0.0 alpha.3 r=ryankurte a=eldruin

Builds on and superseeds #43 and #48.

Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot added a commit that referenced this pull request Nov 7, 2020
@bors @eldruin
Merge #50
ca285f1 
50: Embedded hal 1.0.0 alpha.3 r=ryankurte a=eldruin

Builds on and superseeds #43 and #48.

Co-authored-by: Diego Barrios Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Status: Review is incomplete T-embedded-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldruin @rust-highfive @ryankurte