Skip to content

Remove futures examples #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Oct 7, 2020

The futures-based examples are stuck on futures 0.1, require nightly to run the tests and do not represent how asynchronous processing will be done in embedded any more.
In the 0.2.x version these examples are still present. See here.
See async/await on embedded Rust.
See #251

@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Oct 7, 2020
@ryankurte
Copy link
Contributor

seems okay to drop futures examples for now, your thoughts @therealprof?

@therealprof
Copy link
Contributor

seems okay to drop futures examples for now, your thoughts @therealprof?

Yes, let's do that. We already entertained this idea in #251.

@eldruin eldruin force-pushed the remove-futures-examples branch from ca52642 to 8c22c63 Compare October 8, 2020 07:14
@eldruin eldruin force-pushed the remove-futures-examples branch from 8c22c63 to 23557a5 Compare October 8, 2020 07:24
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors bors bot merged commit 314d25b into rust-embedded:master Oct 8, 2020
@eldruin eldruin deleted the remove-futures-examples branch October 8, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants