-
Notifications
You must be signed in to change notification settings - Fork 83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bors r+ |
147: add thumbv8m baseline r=therealprof a=evq Co-authored-by: eV <[email protected]>
@evq I don't know what the status of thumbv8m as a target in Rust is but we once that is rolling we need to add it to CI. |
I have a PR open to add the baseline target - which is waiting on another PR for a cargo change: |
Build failed |
@evq Maybe open tickets so we don't forget? |
@evq Hm, you used a different toolchain to build this it seems. |
|
Ah, I'm using |
Looks like the version installed in
|
I guess more important is the question: Which one is the better version? |
I think this is correct - right? Since
The ARMv8-M architecture reference manual seems to indicate that the |
You might not have an up to date master - asm.s recently (a week ago)
changed to use b instead of bl.
|
aha, thanks @adamgreig, that'll do it! :) |
bors r+ |
147: add thumbv8m baseline r=thejpster a=evq Co-authored-by: eV <[email protected]>
Build succeeded |
No description provided.