feat: remove inefficient if check on match lex #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…heck on match lex
aa722c228c80aabb1e2e3a7a0f0fe5f4e348c444 feat: remove inefficient if check on match lex (ChrisCho-H)
Pull request description:
I'm not sure whether it's intentional, but this pattern(match and then if) could make lexer little slower for `OP_CSV` and `OP_CLTV`(and `Error::InvalidOpcode`) as they aren't caught in match arms but `if` block like below(which causes additional check).
```rust
...
script::Instruction::Op(op) => {
if op == opcodes::all::OP_CSV {
ret.push(Token::CheckSequenceVerify);
} else if op == opcodes::all::OP_CLTV {
ret.push(Token::CheckLockTimeVerify);
} else {
return Err(Error::InvalidOpcode(op))
}
}
```
ACKs for top commit:
apoelstra:
ACK aa722c228c80aabb1e2e3a7a0f0fe5f4e348c444; successfully ran local tests; nice!
sanket1729:
ACK aa722c228c80aabb1e2e3a7a0f0fe5f4e348c444
Tree-SHA512: d538e9f064cdb55fc2e8cbb8e56532a0ebe0563e9b1227c9a9a84140e5f23c22663ea2a976a8ac19e69bbbb7eb8b517b54d04ea7759747f2dc8370f5f45f0255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether it's intentional, but this pattern(match and then if) could make lexer little slower for
OP_CSVandOP_CLTV(andError::InvalidOpcode) as they aren't caught in match arms butifblock like below(which causes additional check).