Add https support for minreq_http of jsonrpc

[spartucus]

This way, bitcoind-json-rpc-client can use jsonrpc with feature minreq_http for https connection.

[tcharding]

This change somewhat invalidates the feature name. Also I would have expected "start supporting HTTPS" to require more changes than this - did you test this works?

[spartucus]

Also I would have expected "start supporting HTTPS" to require more changes than this - did you test this works?

Yes, for the minreq backend, enable https feature would work for https. I tested it, it works.

This change somewhat invalidates the feature name.

I don't quite understand, you mean "minreq_http" has "https" feature make it inappropriate?

[tcharding]

HTTP is not HTTPS so having a feature called minreq_http that does HTTPS stuff is wrong IMO. I didn't look deeply into it but a bunch of other things are also done with the assumption that we do not support HTTPS (eg, module names, docs etc).

[tcharding]

To clarify, I'm not opposed to the idea, and appreciate you raising a PR, but if we are going to do it we should do it properly.

[spartucus]

Cool, my PR can be regarded as a simple starting point. If people who use this library encounter the error JsonRpc(Transport(Minreq(HttpsFeatureNotEnabled))) when connecting to https in bitcoind service, they can temporarily use my method to solve it.

[tcharding]

Damn, I wish you put that error message and the explanation of why you raised the PR in the original message, the conversation would have been totally different. Anyways, thanks for bringing it up and thanks for using the lib!