Fix trailing <br>s added in lists with EXTENSION_HARD_LINE_BREAK enabled #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, with EXTENSION_HARD_LINE_BREAK enabled, <li>s would contain unnecessary <br />s at the end of each item. It was especially noticeable by the vertical space this left at the end of an ordered or unordered list. This fixes that by stripping trailing <br />s from individual list items while in the process of stripping trailing newlines. One shortcoming of this patch: it does not fix the issue in *nested* lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, with
EXTENSION_HARD_LINE_BREAKenabled,<li>s would contain unnecessary<br />s at the end of each item. It was especially noticeable by the vertical space this left following an ordered or unordered list.This fixes that by also stripping trailing
<br />s from individual list items when this extension is enabled.One shortcoming of this patch: it does not completely fix the issue in nested lists, as far as the markup goes -- but the visual issues are gone, at least. I can work on fully fixing the markup if there's interest in that.
Input: