Remove global sudo from action wrapper#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo -EWhy
Ubuntu 26 ignores
sudo -E, which strips GitHub Actions cache/artifact environment variables before the action binary reads them. That prevents the RunsOn cache proxy from receiving the originalZCTIONS_*URLs andACTIONS_RUNTIME_TOKEN, which breaks artifact upload through the local proxy.The cache configuration path only sends an HTTP request to the local cache daemon and does not need root. Running the wrapper binary as the runner user preserves the GitHub Actions environment normally and avoids forwarding secrets through sudo.
Validation
make jsgo test ./...index.jsandpost.jsno longer contain thesudo -n -Ewrapper