-
Notifications
You must be signed in to change notification settings - Fork 4
Make using renderers and react-console work; support multiple RunmeConsoles #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlewi
wants to merge
32
commits into
main
Choose a base branch
from
jlewi/devconsole
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
fb532ff
Try to add an app console and reproduce the error; Uncaught NotSuppor…
jlewi-openai e5a5bd5
Make custom element registration idempotent
jlewi-openai 708d055
Guard console messaging when context is missing
jlewi-openai e20aa2f
Declare renderers as peer dependency for react-console
jlewi-openai 144dfe7
Externalize runme libs and declare as peers
jlewi-openai 79b7638
Tweak AppConsole welcome message
jlewi-openai 4a54e27
Add stub prompt/echo behavior to AppConsole
jlewi-openai 89380fe
Buffer AppConsole input and add welcome banner
jlewi-openai 09643bb
Allow per-instance console context and wire RunmeConsole
jlewi-openai 2a70530
Let each RunmeConsole use its own messaging context
jlewi-openai dc802e9
Add a commit message.
jlewi-openai cbe57d6
Remove defineCustomElement wrapper and restore decorators
jlewi-openai 10be0d3
Remove unused getContext.
8fc23f5
Allow RunmeConsole to accept injected messaging context
b90a22f
Extract RunmeRenderContext and allow injected contexts
41dcc92
Start building a testApp.
7cdf28c
Revert RunmeRenderContext helper and inline context bridge
0de0fcd
Remove import of getContext.
7a1c3ab
Add testApp consoles using AppConsole stub
1730926
Expose Streams types and add StreamCreator hooks for testing
70890f7
Change definition of streams type to streamslike.
2896c59
Wire testApp consoles to FakeStreams via StreamCreator
bf7890c
Log which Streams factory RunmeConsole uses
7fa7d8b
Clean up testApp
e7a5be0
Add some debug logging; revert this later.
bbd816a
Export FakeStreams and use package fake in testApp
205b226
Add some more logging; testApp seems to be working but you need to re…
e87c99b
Add a README.
044f92f
Remove AppConsole from react-components.
fad5fc4
Fix the lock file.
1baf0b8
Changelog for jlewi dev release.
20ecf08
Revert most changes to the bare minimum to get this to work for myself.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| # @runmedev/react-console | ||
|
|
||
| ## 3.16.5-jlewi.0 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - Test the changes to support renderers and react-console being imported | ||
| - Updated dependencies | ||
| - @runmedev/[email protected] | ||
|
|
||
| ## 3.16.4 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think it'll work to externalize these. The webapp just imports
@runmedev/react-componentsand you shouldn't have to provide these separately. Is this strictly necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably right. I can try reverting this.
Since I'm just importing react-console we can probably revert all the peer dependency changes.