Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commands/benchmark-job/logs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ async function runWithConcurrency<T>(
{ length: Math.min(maxConcurrency, tasks.length) },
() => worker(),
);
await Promise.all(workers);
await Promise.allSettled(workers);
return results;
}

Expand Down Expand Up @@ -349,7 +349,8 @@ export async function downloadBenchmarkJobLogs(
`\nDownloading logs for ${targets.length} scenario run(s) to ${chalk.bold(outputDir)}\n`,
);

// Download logs in parallel with a max concurrency of 50
// Download logs in parallel with a max concurrency of 50.
// Bumping to 100 yields no improvement in simple manual testing.
const MAX_CONCURRENCY = 50;
let succeeded = 0;

Expand Down
Loading