Skip to content

fix: scenarios sometimes listed as in progress after bmj completes#174

Merged
james-rl merged 4 commits intomainfrom
james/krafton-bmj-preview
Mar 17, 2026
Merged

fix: scenarios sometimes listed as in progress after bmj completes#174
james-rl merged 4 commits intomainfrom
james/krafton-bmj-preview

Conversation

@james-rl
Copy link
Contributor

Description

  • Refactored the progress bar to sit in a common location
  • Perform a final round of reconciliation after bmj completes to avoid listing some scenarios as being stuck in "in progress" even though they already finished running.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test updates

Related Issues

Closes #

Changes Made

Testing

  • I have tested locally (but this is hard to reproduce)
  • I have added/updated tests
  • All existing tests pass

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@james-rl james-rl merged commit 78f8f55 into main Mar 17, 2026
14 checks passed
@james-rl james-rl deleted the james/krafton-bmj-preview branch March 17, 2026 18:10
dines-rl pushed a commit that referenced this pull request Mar 25, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.14.0](v1.13.3...v1.14.0)
(2026-03-25)


### Features

* add 'logs' command to download info from devboxes
([#164](#164))
([d5354be](d5354be))
* use total_count field from Pagination API response
([#175](#175))
([4e84f30](4e84f30))


### Bug Fixes

* **benchmark:** fix benchmark id when creating job with benchmark
([#170](#170))
([2c73cba](2c73cba))
* bmj list now counts finished scenarios from in-progress runs
([#168](#168))
([123f1d4](123f1d4))
* **cli:** show failure reason when benchmark job fails with no outcomes
([#182](#182))
([817b5cd](817b5cd))
* **cli:** use allSettled() instead of all() so one bad download doesn't
spoil the barrel
([#178](#178))
([8f4145a](8f4145a))
* don't reset TUI menu cursor on back
([#181](#181))
([6cc35a7](6cc35a7))
* eliminate flicker in bmj watch and show job elapsed time
([#167](#167))
([9b1deed](9b1deed))
* prevent double devbox creation when pressing Enter in interactive form
([#173](#173))
([23f8a28](23f8a28))
* scenarios sometimes listed as in progress after bmj completes
([#174](#174))
([78f8f55](78f8f55))
* update broken tests
([#169](#169))
([d8b35a2](d8b35a2))


### Performance Improvements

* **cli:** parallelize scenario log downloads with max concurrency of 50
([#176](#176))
([a5828a2](a5828a2))
* **cli:** parallelize scenario run fetching and name resolution in bmj
logs ([#179](#179))
([227d0fd](227d0fd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants