Skip to content

fix: scenarios sometimes listed as in progress after bmj completes#174

Merged
james-rl merged 4 commits intomainfrom
james/krafton-bmj-preview
Mar 17, 2026
Merged

fix: scenarios sometimes listed as in progress after bmj completes#174
james-rl merged 4 commits intomainfrom
james/krafton-bmj-preview

Conversation

@james-rl
Copy link
Contributor

Description

  • Refactored the progress bar to sit in a common location
  • Perform a final round of reconciliation after bmj completes to avoid listing some scenarios as being stuck in "in progress" even though they already finished running.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test updates

Related Issues

Closes #

Changes Made

Testing

  • I have tested locally (but this is hard to reproduce)
  • I have added/updated tests
  • All existing tests pass

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@james-rl james-rl merged commit 78f8f55 into main Mar 17, 2026
14 checks passed
@james-rl james-rl deleted the james/krafton-bmj-preview branch March 17, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants