fix(tui): allow typing 'q' in snapshot name/commit_message fields#172
Open
rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
Open
fix(tui): allow typing 'q' in snapshot name/commit_message fields#172rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
Conversation
The snapshot form's useInput handler was treating 'q' as a cancel key unconditionally, so typing 'q' in the Name or Commit Message fields would cancel the entire form instead of inserting the character. Only allow 'q' to cancel when not focused on a text input field; Escape always cancels regardless of field. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useInputhandler was treatingqas a cancel key unconditionallyqwhile focused on the Name or Commit Message text fields would cancel the form instead of inserting the characterqas cancel when NOT focused on a text input field;Escapealways cancelsTest plan
q(e.g.my-snapshot-q) — should now insert correctly instead of cancellingEscapestill cancels the form from both text fields and non-text fieldsqstill cancels the form when focused on the Metadata or Create fields🤖 Generated with Claude Code