refactor: eliminate code duplication in parse utilities and log formatting#171
Open
rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
Open
refactor: eliminate code duplication in parse utilities and log formatting#171rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
Conversation
…rmatter - Add src/utils/parse.ts with shared parseEnvVars and parseSecrets functions - Remove duplicate definitions from devbox/create.ts and benchmark-job/run.ts - Replace duplicate formatLogLevel/formatTimestamp in blueprint/logs.ts with imports from logFormatter.ts (getLogLevelInfo and formatTimestamp) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseEnvVarsandparseSecretsfunctions fromdevbox/create.tsandbenchmark-job/run.tsinto a new sharedsrc/utils/parse.tsutilityblueprint/logs.tsto useformatTimestampandgetLogLevelInfoalready exported fromsrc/utils/logFormatter.ts, removing ~50 lines of duplicate timestamp/level formatting logicTest plan
rli devbox createstill works with--env-varsand--secretsflagsrli benchmark-job runstill works with--env-varsand--secretsflagsrli blueprint logs <id>still formats log output correctly🤖 Generated with Claude Code