Skip to content

fix(benchmark): fix benchmark id when creating job with benchmark #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ross-rl merged 1 commit into from
Mar 13, 2026
Merged

fix(benchmark): fix benchmark id when creating job with benchmark #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/commands/benchmark-job/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,8 @@ async function ensureAgentSecrets(

// Resolve benchmark name to ID if needed
async function resolveBenchmarkId(benchmarkIdOrName: string): Promise<string> {
// If it looks like an ID (starts with bm_ or similar), return as-is
if (
benchmarkIdOrName.startsWith("bm_") ||
benchmarkIdOrName.startsWith("bmk_")
) {
// If it looks like a benchmark ID, return as-is
if (benchmarkIdOrName.startsWith("bmd_")) {
return benchmarkIdOrName;
}

Expand Down Expand Up @@ -346,7 +343,7 @@ export async function runBenchmarkJob(options: RunOptions) {
console.log(
`Benchmark job created: ${job.id} (agent timeout = ${agentConfigs[0].timeoutSeconds}s)`,
);
console.log(`Follow the run with rli benchmark-job watch ${job.id}`);
console.log(`Follow the run with "rli benchmark-job watch ${job.id}"`);
} else {
output(job, { format: options.output, defaultFormat: "json" });
}
Expand Down
Loading