Prevent busy-loop when tcmulib_processing_start fails#16
Merged
Conversation
When tcmulib_processing_start fails to read the UIO device, it logs an error but produces no commands. Without yielding, the event loop spins at 100% CPU, starving the master netlink loop and preventing new devices from being configured. Sleep 1ms when no commands are available to break the spin. Co-Authored-By: Claude Opus 4.6 <[email protected]>
gautam-rl
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tcmulib_processing_start fails to read the UIO device, it logs an error but produces no commands. Without yielding, the event loop spins at 100% CPU, starving the master netlink loop and preventing new devices from being configured.
Sleep 1ms when no commands are available to break the spin.