Open
Conversation
adam-rl
reviewed
Mar 11, 2026
|
|
||
| // Count blocks that will be overwritten (rewritten) | ||
| uint64_t rewritten = 0; | ||
| auto check_it = mapping.lower_bound(m); |
There was a problem hiding this comment.
So this is in the hot path, serving block reads, and we've introduced another lookup.
Should this be somehow gated with a preprocessor guard, and only enabled when building the overlaybd-commit tool?
adam-rl
reviewed
Mar 11, 2026
| return; | ||
| } | ||
|
|
||
| it = remove_partial_overlap(it, m.offset, m.length); // first one (there must be) |
There was a problem hiding this comment.
Could we instead have this method return how many blocks were removed?
This code is already figuring out what was overwritten, it can just report that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.