Conversation
sid-rl
reviewed
Mar 6, 2026
| """ | ||
| return Secret(self._client, name) | ||
|
|
||
| def update( |
Contributor
There was a problem hiding this comment.
having an update() method in both the Ops class and the object class feels redundant. we should only have it in one (i think within the Secrets class itself) so that there's one canonical way to update secrets.
| """ | ||
| name = secret if isinstance(secret, str) else secret.name | ||
| self._client.secrets.update(name, value=value, **options) | ||
| return Secret(self._client, name) |
Contributor
There was a problem hiding this comment.
we should pass id into the return object
| :type client: AsyncRunloop | ||
| :param name: The globally unique name of the secret | ||
| :type name: str | ||
| :param id: The secret ID (optional, may not be known until get_info is called) |
Contributor
There was a problem hiding this comment.
is this a paradigm we want to incorporate across the rest of the oo-sdk as well? feels a bit weird that this is the only class that implements it, if we want to go this route
stainless-app
bot
force-pushed
the
next
branch
2 times, most recently
from
5dfcd93 to
8428682
Compare
Merged
stainless-app bot
added a commit
that referenced
this pull request
Mar 18, 2026
Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered that there was a gap in our oo-sdk. Secrets now have coverage.
Also added examples