Merged
Conversation
- Renamed test_create_and_remove_tunnel to test_create_tunnel_deprecated - Removed tunnel removal attempt that was causing 400 error - Added verification that v2 tunnel persists in devbox info - Updated docstrings to clarify v2 tunnels cannot be removed - Applied fix to both sync and async test files Co-authored-by: albert <alb-rl@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
- Fixed type checking errors in tunnel tests - Changed devbox.info() to devbox.get_info() in both sync and async tests Co-authored-by: albert <alb-rl@users.noreply.github.com>
Co-authored-by: albert <alb-rl@users.noreply.github.com>
jason-rl
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Python API client smoketests to reflect that deprecated
create_tunnelcreates unremovable v2 Portal tunnels.The previous
test_create_and_remove_tunnelwas failing due to a 400 error when attempting to remove a tunnel created by the deprecatedcreate_tunnelendpoint. This is because the deprecated endpoint now provisions v2 Portal tunnels, which cannot be removed using the oldremove_tunnelmethod. This PR updates the tests to reflect this behavior, ensuring the test passes and accurately represents the current API functionality.Slack Thread