feat(scenarios): add scenario builder to sdk#706
Merged
Conversation
sid-rl
force-pushed
the
siddarth/scenario-builder-sdk
branch
from
4ffbf98 to
980a9ff
Compare
sid-rl
commented
Dec 9, 2025
james-rl
reviewed
Dec 9, 2025
sid-rl
force-pushed
the
siddarth/scenario-builder-sdk
branch
3 times, most recently
from
341c74d to
f1b1ca6
Compare
james-rl
requested changes
Dec 9, 2025
Contributor
james-rl
left a comment
james-rl
left a comment
There was a problem hiding this comment.
Some feedback for helpful docstring messages.
…rage matches sync
…ces to RunloopSDK() to 'runloop' instead of 'sdk' or 'client'
sid-rl
force-pushed
the
siddarth/scenario-builder-sdk
branch
from
177dbda to
034399b
Compare
sid-rl
changed the title
james-rl
requested changes
Dec 11, 2025
Contributor
james-rl
left a comment
james-rl
left a comment
There was a problem hiding this comment.
This looks very close to being ready. The only change I think you need to make is to have the builder use a build() method and then to call push() on the constructed object.
Just to be clear, this is not a matter of correctness, it's about adhering to conventions and user expectations.
| "validation_type": self._validation_type, | ||
| } | ||
|
|
||
| def preview(self) -> ScenarioPreview: |
james-rl
approved these changes
Dec 11, 2025
Contributor
james-rl
left a comment
james-rl
left a comment
There was a problem hiding this comment.
Looks good to me, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.