Conversation
wall-rl
approved these changes
Nov 22, 2025
wall-rl
changed the title
dines-rl
reviewed
Nov 24, 2025
| @@ -0,0 +1,67 @@ | |||
| """Agent resource class for asynchronous operations.""" | |||
|
|
|||
Contributor
Author
|
@dino - FYI, I made a new branch from Jon's PR, and have added / fixed some
things there. We can safely consider this PR abandoned. (And adding tests
is one of the bits I've done --- although I'll def want feedback on whether
or not I've found all of the reasonable places / followed the existing test
style well. :)
…On Mon, Nov 24, 2025 at 11:53 AM Alexander Dines ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/runloop_api_client/sdk/async_agent.py
<#691 (comment)>
:
> @@ -0,0 +1,67 @@
+"""Agent resource class for asynchronous operations."""
+
needs smoke tests
—
Reply to this email directly, view it on GitHub
<#691 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BYWPRMBXKWPQQPMDWFZ6YHD36NO4PAVCNFSM6AAAAACM4HM3YWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMBSGAYTQMRWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jrvb-rl
force-pushed
the
jrvb-wall-agent
branch
from
fcaab24 to
3bf240b
Compare
dines-rl
reviewed
Nov 26, 2025
| ) -> Agent: | ||
| """Create a new agent. | ||
|
|
||
| :param params: See :typeddict:`~runloop_api_client.sdk._types.SDKAgentCreateParams` for available parameters |
Contributor
There was a problem hiding this comment.
not trying to overload this pr but would be great to have createFromNpmPackage(pkgname, ect), one for each type so the user doesn't have to figure out our weird format
Contributor
Author
There was a problem hiding this comment.
Oh right! Good point. If it's quick, I'll do it here; if not I'll do as a follow-on PR
jrvb-rl
force-pushed
the
jrvb-wall-agent
branch
from
6cfd4c4 to
ea7b0b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forked from wall-rl's:
#683
Rebased to main, and added a few fixes