Skip to content

Skip strict mode tests for flakey tests#614

Merged
alb-rl merged 2 commits intomainfrom
alb/fix-tests
Jul 10, 2025
Merged

Skip strict mode tests for flakey tests#614
alb-rl merged 2 commits intomainfrom
alb/fix-tests

Conversation

@alb-rl
Copy link
Copy Markdown
Contributor

@alb-rl alb-rl commented Jul 10, 2025

pydantic is used to validate the schema of the JSON structure. However, the mock server comes generates invalid data for complex nested types. The API calls succeed, headers were correct, JSON parsing works, so we are probably safe to ignore this extra validation.

  1. Loose validation tests continue to work - testing that the API client can handle real-world data
  2. Strict validation tests are skipped - avoiding false failures due to mock server limitations

@alb-rl alb-rl changed the title Skip strict mode tests Skip strict mode tests for flakey tests Jul 10, 2025
@alb-rl alb-rl requested a review from tode-rl July 10, 2025 22:14
Copy link
Copy Markdown
Contributor

@tode-rl tode-rl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lsp isn't even fully supported yet?

@alb-rl alb-rl merged commit 3586007 into main Jul 10, 2025
7 checks passed
@alb-rl alb-rl deleted the alb/fix-tests branch July 10, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants