-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add red-prison-sentence plugin #7939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New plugin |
Internal use only: Reviewer details Maintainer details |
it seems like this would hammer the hiscores and potentially get you rate limited, can you add a minimum cooldown between lookups? |
Thanks for the review @LlemonDuck |
It seems like you would still be making (potentially large) request bursts if many players are loaded at once, and looks like you might not have restricted fetching to the area, which would make this even more likely. |
you can also remove bin/ |
gitignore bin folder
I've updated the plugin to only send 1 lookup request every 5 seconds (feel like this should be fairly reasonable) let me know if it need adjusting further. The plugin currently by default only looks up players while in the gauntlet lobby, but the player can enable an option to enable everywhere (should be okay now with the rate limiting). Removed the |
Red Prison Sentence Plugin
A plugin to display players time served within the corrupted gauntlet