Skip to content

Add red-prison-sentence plugin #7939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

RedSparr0w
Copy link

Red Prison Sentence Plugin

A plugin to display players time served within the corrupted gauntlet

image

image
image

@runelite-github-app
Copy link

runelite-github-app bot commented May 3, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented May 3, 2025

Internal use only: Reviewer details Maintainer details

Fix not checking clanmates and friends
@LlemonDuck
Copy link
Contributor

it seems like this would hammer the hiscores and potentially get you rate limited, can you add a minimum cooldown between lookups?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@RedSparr0w
Copy link
Author

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@tylerwgrass
Copy link
Member

It seems like you would still be making (potentially large) request bursts if many players are loaded at once, and looks like you might not have restricted fetching to the area, which would make this even more likely.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@LlemonDuck
Copy link
Contributor

you can also remove bin/

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@RedSparr0w
Copy link
Author

I've updated the plugin to only send 1 lookup request every 5 seconds (feel like this should be fairly reasonable) let me know if it need adjusting further.

The plugin currently by default only looks up players while in the gauntlet lobby, but the player can enable an option to enable everywhere (should be okay now with the rate limiting).

Removed the bin/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants