Skip to content

Update clean-chat to 1.0.6 #7936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ldavid432
Copy link
Contributor

@ldavid432 ldavid432 commented May 2, 2025

Wouldn't let me reopen cause I force pushed, oops

@runelite-github-app
Copy link

runelite-github-app bot commented May 2, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented May 2, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@ldavid432 ldavid432 changed the title Update clean-chat to 1.0.4 Update clean-chat to 1.0.5 May 3, 2025
@ldavid432 ldavid432 changed the title Update clean-chat to 1.0.5 Update clean-chat to 1.0.6 May 6, 2025
@LlemonDuck
Copy link
Contributor

do you need 5 threads in your executor service?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@ldavid432
Copy link
Contributor Author

do you need 5 threads in your executor service?

I just wanted to protect against a bunch of chat commands being sent at once (mainly possibly an incorrect one, which would block the executor), although I think spamming commands typically happens in public which I don't deal with so probably not as common as I'm thinking.

Would it be better to just have 1 or 2?

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding clan name name option breaks commands like !task within the cc
2 participants