Skip to content

Update ge-filters to new working version 1.13 #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

Nick2bad4u
Copy link

@Nick2bad4u Nick2bad4u commented Apr 29, 2025

Update ge-filters to new working version 1.13

Pushing update for @salverrs as I am a contributor on the project.
(Have edit permission to merge mine / other changes - Salverss has been offline for a while, so I pushed a new update for him)

Had to match new IDs for widgets.

Project Repo: GEFilters Repo

Contributors: GEFilters Contribs

Commits: https://github.com/salverrs/GE-Filters/commits/master/

Latest Hash: a2a1f66a3343cdafc02bbc83e96c2d63c746baa1https://github.com/salverrs/GE-Filters/tree/a2a1f66a3343cdafc02bbc83e96c2d63c746baa1

Pushing update for @salverrs as I am a contributor on the project.
@runelite-github-app
Copy link

runelite-github-app bot commented Apr 29, 2025

Includes changes by non-author

ge-filters: 0128abaef76aaa9d12ef7b2e18b67e75fa911a1c...a2a1f66a3343cdafc02bbc83e96c2d63c746baa1

@runelite-github-app
Copy link

runelite-github-app bot commented Apr 29, 2025

Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Contributor

Do you have anything indicating that you're free to push updates on @salverrs behalf? Otherwise we'll need a confirmation from them.

@salverrs if you'd like to permanently give permission for @Nick2bad4u to push updates, you can also let us know and Nick can add themselves to the authors= line of this manifest.

@Nick2bad4u
Copy link
Author

Nick2bad4u commented Apr 30, 2025

Do you have anything indicating that you're free to push updates on @salverrs behalf? Otherwise we'll need a confirmation from them.

@salverrs if you'd like to permanently give permission for @Nick2bad4u to push updates, you can also let us know and Nick can add themselves to the authors= line of this manifest.

I have been trying to contact him for a month or so, since someone else dm'd me on discord about fixing it.

I have an old thread where he added me as a collab on the project (let's me merge any change to the repo)

salverrs/GE-Filters#8

Screenshot_20250430_013120_GitHub.png

He mentioned here in the thread above adding me as a project collaborator for any future updates that borked the plugin.

I'm not sure how collab permissions work but you can see I've committed directly to the repo yesterday, which requires the author to give permission to my GitHub account somehow.

@LlemonDuck
Copy link
Contributor

Unfortunately we consider write permissions separate from releasing to hub. If the author has been unreachable, we have a plugin takeover policy if you'd like to begin that process.

@Nick2bad4u
Copy link
Author

Nick2bad4u commented Apr 30, 2025

Unfortunately we consider write permissions separate from releasing to hub. If the author has been unreachable, we have a plugin takeover policy if you'd like to begin that process.

Hmm. I really don't want to steal his project because he's probably inactive for now, but will come back eventually.

But if I have no other choice between stealing the project or leaving the plugin completely dead I guess I have to take it over.

I added myself as an author to the runelite.properties but I guess I need to go further

@tylerwgrass
Copy link
Member

you are supposed to add yourself as an author in the file in this PR, not the one in the actual plugin repo.

@Nick2bad4u
Copy link
Author

Nick2bad4u commented May 1, 2025

you are supposed to add yourself as an author in the file in this PR, not the one in the actual plugin repo.

Done.

I can add multiple names right?

I opened a new PR to take it over so this pr doesn't matter anymore I think.

#7921

@LlemonDuck LlemonDuck closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants