Repository navigation
[RUN-4806] Add User-Agent header to api_call requests - #84
Merged
Merged
Conversation
smartinellibenedetti
force-pushed
the
sdk-update
branch
from
August 19, 2026 23:32
ccd7b2e to
72de772
Compare
Sends "rundeck-mcp/<version>" on every outbound API call. The version is baked into src/tools/api.ts's USER_AGENT constant at build time by a new CI step (guarded by a strict vX.Y.Z tag format check to avoid shell injection via CIRCLE_TAG), so branch/PR builds keep the SNAPSHOT default. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sets server.json's version fields to "SNAPSHOT" as the placeholder, matching src/tools/api.ts's USER_AGENT, and extends the CI build step's sed replacement to patch both so server.json doesn't drift from the actual release version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
smartinellibenedetti
force-pushed
the
custom-agent-header
branch
from
August 20, 2026 00:26
6e13b42 to
b8a9cd2
Compare
smartinellibenedetti
changed the title
fdevans
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rundeck-mcp/<version>as theUser-Agentheader on everyapi_callrequest (also coversrunner_create/acl_manage, which call through it).src/tools/api.ts'sUSER_AGENTconstant at CI build time by a new step in.circleci/config.yml'sbuildjob, guarded by a strictvX.Y.Ztag-format check before use (CIRCLE_TAGis otherwise interpolated unsanitized into a shell command, which git's permissive ref-name rules make a theoretical injection vector). Branch/PR builds keep theSNAPSHOTdefault.Note: base is set to
sdk-update(#83) since that PR should merge first.Test plan
npm run buildnpm test(320/320 passing)sedtarget pattern (rundeck-mcp/SNAPSHOT) is unique in the codebase🤖 Generated with Claude Code