-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat json schema #329
Feat json schema #329
Conversation
could you bump the version please? |
@jamengual Thanks done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @roytev! Left some comments/suggestions.
Co-authored-by: Gabriel Martinez <[email protected]>
@GMartinez-Sisti Thanks! ive made the requested changes |
Co-authored-by: Gabriel Martinez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
what
why
tests
references