Fix parsing of centered borderless tables - #386
Draft
ShiyuanHsu wants to merge 1 commit into
Draft
Conversation
Contributor
|
For changes to markdown, I would recommend re-running ParseBench -- we have tracked results there so its worth checking if this impacts performance there. I can always run it too if thats too annoying. I usually just point claude code or codex at it and let it wire up a local build for testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
For centered cell text, varying text widths change the left edges while the column centers remain aligned. XY-cut interpreted the whitespace between those columns as page-column gutters and split one logical table into separate regions. The Markdown classifier then received column-wise text instead of complete table rows.
Validation
cargo test -p liteparse --no-default-features --lib centered_text_table_obstacle -- --nocapture