Skip to content

Modules pr only followup #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rufinv merged 2 commits into from
Jan 26, 2026
Merged

Modules pr only followup #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4a8dc
Make selection_mod optional without breaking positional args
RolandBERTINJOHANNET Jan 26, 2026
6c21ae7
Merge remote-tracking branch 'origin/main' into modules-pr-only-followup
RolandBERTINJOHANNET Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shimmer/modules/global_workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,6 @@ def __init__(
workspace_dim: int,
loss_coefs: LossCoefs | Mapping[str, float],
selection_temperature: float = 0.2,
selection_mod: SelectionBase | None = None,
optim_lr: float = 1e-3,
optim_weight_decay: float = 0.0,
scheduler_args: SchedulerArgs | None = None,
Expand All @@ -732,6 +731,7 @@ def __init__(
| None
| OneCycleSchedulerSentinel = OneCycleSchedulerSentinel.DEFAULT,
fusion_activation_fn: Callable[[torch.Tensor], torch.Tensor] = torch.tanh,
selection_mod: SelectionBase | None = None,
) -> None:
"""
Initializes a Global Workspace
Expand Down Expand Up @@ -765,6 +765,8 @@ def __init__(
no scheduler will be used. Defaults to use OneCycleScheduler
fusion_activation_fn (`Callable[[torch.Tensor], torch.Tensor]`): activation
function to fuse the domains.
selection_mod (`SelectionBase | None`): optional custom selection module.
If None (default), uses `RandomSelection`.
"""
domain_mods = freeze_domain_modules(domain_mods)
gw_mod = GWModule(
Expand Down