Skip to content

Conversation

@kjarosh
Copy link
Member

@kjarosh kjarosh commented Dec 9, 2025

These tests verify declarations of global objects and their prototypes, so that we can track how they are defined and with what flags.

@kjarosh kjarosh added A-tests Area: Tests & Test Framework T-compat Type: Compatibility with Flash Player labels Dec 9, 2025
@moulins
Copy link
Contributor

moulins commented Dec 10, 2025

Isn't that already covered by the from_gnash/actionscript/all/argtests tests?

@kjarosh
Copy link
Member Author

kjarosh commented Dec 10, 2025

Nope, the main point of argstest is to call everything and check if it crashes, it does not verify the prototype at all. The common part is iteration order and sometimes some properties, but argstest also lacks flag checking.

@kjarosh kjarosh added the waiting-on-review Waiting on review from a Ruffle team member label Dec 10, 2025
@kjarosh kjarosh force-pushed the proto-decls branch 2 times, most recently from 8b2d53d to c963d10 Compare December 11, 2025 21:00
@kjarosh
Copy link
Member Author

kjarosh commented Dec 11, 2025

Marked owned properties as "own".

These tests verify declarations of global objects and their prototypes,
so that we can track how they are defined and with what flags.
@kjarosh kjarosh enabled auto-merge (rebase) December 12, 2025 18:30
@kjarosh kjarosh removed the waiting-on-review Waiting on review from a Ruffle team member label Dec 12, 2025
@kjarosh kjarosh merged commit 016f8b0 into ruffle-rs:master Dec 12, 2025
26 checks passed
@kjarosh kjarosh deleted the proto-decls branch December 12, 2025 18:40
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Dec 14, 2025
------------------------------------------------------------------------------------------
dolphin-emu.mk 04f71e5e6d6b7fd3736b8b1f60f7970b34ec1e3f # Version: Commits on Dec 12, 2025
------------------------------------------------------------------------------------------
Merge pull request #14211 from cscd98/enumerate-radios

mingw: fix usage of std::invocable with EnumerateRadios,

--------------------------------------------------------------------------------------
flycast.mk 37a9077304908196193b20d5f314dd86fe0578e1 # Version: Commits on Dec 12, 2025
--------------------------------------------------------------------------------------
Fetch translations & Recreate libretro_core_options_intl.h,

------------------------------------------------------------------------------------
rpcs3.mk 0c455d12c9d8c57569ff816f65aa6ba1cc14e16c # Version: Commits on Dec 12, 2025
------------------------------------------------------------------------------------
Fix int -> float conversion warning,

---------------------------------------------------------------
ruffle.mk nightly-2025-12-13 # Version: Commits on Dec 13, 2025
---------------------------------------------------------------
## What's Changed

* chore: Bump some NPM dependencies in web by @torokati44 in ruffle-rs/ruffle#22483

* web: Fix wording to clarify test checks for no Ruffle polyfill by @danielhjacobs in ruffle-rs/ruffle#22484

* avm2: Minor fixes to Array's prototype and `toLocaleString` by @Lord-McSweeney in ruffle-rs/ruffle#22456

* tests: Add avm1/global_proto_decls* tests by @kjarosh in ruffle-rs/ruffle#22467

* core: Remove some unused error variants by @Lord-McSweeney in ruffle-rs/ruffle#22495

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-12-12...nightly-2025-12-13,

------------------------------------------------------------------------------------
box64.mk 466e5eb84b34f592666f9bf1563e058157849755 # Version: Commits on Dec 12, 2025
------------------------------------------------------------------------------------
[LA64_DYNAREC] Fixed 1 more regression intoduced by the prefix refactor (#3265),

----------------------------------------------------------------------------------------
openmohaa.mk 3e16d8a2ff04eaf434cf57f66b7eab0ec4ba3285 # Version: Commits on Dec 12, 2025
----------------------------------------------------------------------------------------
refactor(cmake): define the version in one place (identity file),

----------------------------------------------------------------------------------------
supertux2.mk 4f96c642061d341a31507a5020c50beff12ca6ed # Version: Commits on Dec 13, 2025
----------------------------------------------------------------------------------------
logger: --log-tinygettext to show tinygettext logs

With --debug, tinygettext tends to completely shit up the place. Despite that,

these logs are still useful, but they often get in the way of finding issues...

The approach here is pretty gross, but it's not like this setting is in the

config, so I just expose it lazily. It'll do for now.

Signed-off-by: Swagtoy <[email protected]>,

----------------------------------------------------------------------------------------
retroarch.mk 11cd891eafdaa685a206def234f22f04ac266fe7 # Version: Commits on Dec 13, 2025
----------------------------------------------------------------------------------------
Fetch translations from Crowdin,

----------------------------------------------------------------------------------------
doomretro.mk 36bc8a509fc90e923fecb983695e40fb4ff348fd # Version: Commits on Dec 13, 2025
----------------------------------------------------------------------------------------
Update copyright year in fineprint on splash screen,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk d94677cd17c7315006e54b3d64774a26db200bcd # Version: Commits on Dec 13, 2025
---------------------------------------------------------------------------------------------
(libretro) update files,

-----------------------------------------------------------------------------------------------
libretro-flycast.mk 37a9077304908196193b20d5f314dd86fe0578e1 # Version: Commits on Dec 12, 2025
-----------------------------------------------------------------------------------------------
Fetch translations & Recreate libretro_core_options_intl.h,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 20d4130f391a2cbf3b9aeebd9fb23ff3bd8b60bf # Version: Commits on Dec 13, 2025
---------------------------------------------------------------------------------------------
build: add Homebrew openssl to prefix path

When building with Mac Homebrew, also add OpenSSL to

`include_directories()` and `CMAKE_PREFIX_PATH`.

Signed-off-by: Rafael Kitover <[email protected]>,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Tests & Test Framework T-compat Type: Compatibility with Flash Player

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants