core/avm2: Make all uncaught errors go through Avm2::uncaught_error
#22455
+235
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of `Activation`
- Remove an old comment - Use `Avm2StageObject::for_display_object` and avoid constructing an `Activation`
`sound_object::play_queued` returned a `Result`, but never returned the error variant
This function should be called when an uncaught AVM2 error needs to be logged. Currently, it just prints the error, but in the future it should also dispatch an `uncaughtError` event.
The function never returned an error
This fixes a panic when the `Bitmap` constructor throws an error
Also: - Remove some old TODO comments - Don't log errors that appear when getting original value of property
Lord-McSweeney
added
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, this will allow us to easily implement
toStringon all uncaught errorsUncaughtErrorEvents