web: Polyfill document.embeds to return ruffle-embeds too #22449
+186
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-web
Member
|
Can we add a polyfill test for it? |
Contributor
Author
|
Done |
kjarosh
reviewed
Dec 9, 2025
web/packages/selfhosted/test/polyfill/document_embeds/expected.html
Outdated
Show resolved
Hide resolved
danielhjacobs
force-pushed
the
polyfill-document-embeds
branch
from
598d8f0 to
389d766
Compare
Collaborator
|
This breaks documen.embeds == document.embeds and probably other invariants. |
danielhjacobs
force-pushed
the
polyfill-document-embeds
branch
from
389d766 to
15592b4
Compare
Contributor
Author
Fixed in the latest commit |
danielhjacobs
force-pushed
the
polyfill-document-embeds
branch
from
15592b4 to
cfe5234
Compare
danielhjacobs
force-pushed
the
polyfill-document-embeds
branch
from
cfe5234 to
59263f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.