avm2: Set EditText width during creation #22373
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The tests fail, so this does seem quite correct. It should be noted that the doc for the width parameters says 'Specifies the desired width of the line in pixels. The actual width may be less. '. Maybe the right solution is some sort of compromise? |
danielhjacobs
added
A-avm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12490.
I do not fully understand this tbh and not sure if this is the correct fix.
What happens is that the game tries to cache movie clips using bitmaps and without this fix the bounds of the movieclip are absolutely massive, resulting in a bitmap so big that it is invalid. (The width of the TextEdit is set to the default 1 000 000 from the createTextLine method signature: https://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/text/engine/TextBlock.html#createTextLine().
I expect that this will need a test, but I do not want to waste time on this before it is vibe-checked by someone who has a proper understanding of this code area.