avm2: Store PerspectiveProjection to DisplayObject

[cookie-s]

Continued from #19532 .

DisplayObject stores Option<PerspectiveProjection> through Transform so we can remove HAS_PERSPECTIVE_PROJECTION_STUB flag from display objects.

The test from_shumway/avm2/flash/geom/perspectiveprojection passes now.

Limitation

PerspectiveProjection is stored in Transform, but it's not used in rendering at all. (Hence, we cannot remove stub_setters)

[cookie-s]

I believe the output.txt is from https://github.com/mozilla/shumway/blob/master/test/swfs/avm2/flash/geom/perspectiveprojection/PerspectiveProjectionClass.swf.trace .
I couldn't reproduce exactly the same result from PerspectiveProjectionClass.as in the same directory (after recompilation with mxmlc) or even from the test.swf (without recompilation).

(Fun fact: I was able to pass this test without this approximation until #19748 was merged -- What does it mean? Anyway, I think the problem is that I cannot reproduce the output.txt from ActionScript or SWF.)

[Lord-McSweeney]

I think a small difference like this isn't a problem, we have similar issues with some of the AVM2 Number tests already.

[Lord-McSweeney]

Hmm, does this really return a new PerspectiveProjection each time the getter is called?

[cookie-s]

Yes, to make it clear, I added a test case testEq() to geom_transform just now.
From the same Transform, every call to the getter creates a new PerspectiveProjection.

[Lord-McSweeney]

Is this line necessary?

[cookie-s]

Yes, this line actually sets PerspectiveProjection::default() to DO's PerspectiveProjection.

ruffle/core/src/display_object/stage.rs

Lines 894 to 896 in aa6197e

	if perspective_projection.is_none() {
	// `stage` doesn't allow null PerspectiveProjection.
	perspective_projection = Some(Default::default());

Technically it's fine to set PerspectiveProjection::default() directly at here, but for consistency with root.set_perspective_projection() in a different file I'm passing None here.

ruffle/core/src/context.rs

Line 397 in aa6197e

root.set_perspective_projection(self.gc(), None); // Set default PerspectiveProjection

The root actually has a different value used when None (null) is provided..

ruffle/core/src/display_object/movie_clip.rs

Lines 2836 to 2845 in aa6197e

	if perspective_projection.is_none() && self.is_root() {
	// `root` doesn't allow null PerspectiveProjection.
	perspective_projection = Some(PerspectiveProjection {
	field_of_view: 55.0,
	center: (
	self.movie().width().to_pixels() / 2.0,
	self.movie().height().to_pixels() / 2.0,
	),
	});
	}

[cookie-s]

Thank you for review!

[cookie-s]

Yes, to make it clear, I added a test case testEq() to geom_transform just now.
From the same Transform, every call to the getter creates a new PerspectiveProjection.

[cookie-s]

Yes, this line actually sets PerspectiveProjection::default() to DO's PerspectiveProjection.

ruffle/core/src/display_object/stage.rs

Lines 894 to 896 in aa6197e

	if perspective_projection.is_none() {
	// `stage` doesn't allow null PerspectiveProjection.
	perspective_projection = Some(Default::default());

Technically it's fine to set PerspectiveProjection::default() directly at here, but for consistency with root.set_perspective_projection() in a different file I'm passing None here.

ruffle/core/src/context.rs

Line 397 in aa6197e

root.set_perspective_projection(self.gc(), None); // Set default PerspectiveProjection

The root actually has a different value used when None (null) is provided..

ruffle/core/src/display_object/movie_clip.rs

Lines 2836 to 2845 in aa6197e

	if perspective_projection.is_none() && self.is_root() {
	// `root` doesn't allow null PerspectiveProjection.
	perspective_projection = Some(PerspectiveProjection {
	field_of_view: 55.0,
	center: (
	self.movie().width().to_pixels() / 2.0,
	self.movie().height().to_pixels() / 2.0,
	),
	});
	}

[Dinnerbone]

I've fixed the rebase conflict.

Thank you so much!