Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: Don't test on Edge as the latest release is missing for Linux" #17255

Closed
wants to merge 1 commit into from

Conversation

torokati44
Copy link
Member

Reverts #17253
To be merged once MicrosoftEdge/EdgeWebDriver#156 is fixed.

@torokati44
Copy link
Member Author

torokati44 commented Jul 25, 2024

I wonder whether this is a wdio bug - why doesn't it try to use the installed Edge WebDriver 126.0.2592.102 (even though Edge is 126.0.2592.113)?
Or maybe it's a GHA hosted Ubuntu image bug, since ideally the installed versions should match exactly?

@danielhjacobs
Copy link
Contributor

Or maybe it's a GHA hosted Ubuntu image bug, since ideally the installed versions should match exactly?

I did open actions/runner-images#10336

@torokati44 torokati44 force-pushed the revert-17253-danielhjacobs-patch-2 branch from 0d91ffd to 801724f Compare July 27, 2024 13:14
@torokati44 torokati44 marked this pull request as ready for review July 27, 2024 13:29
@torokati44
Copy link
Member Author

Looks like this works now, @danielhjacobs. Let's hope it doesn't reoccur soon...

@torokati44 torokati44 force-pushed the revert-17253-danielhjacobs-patch-2 branch from 801724f to a4bf857 Compare July 28, 2024 10:20
@torokati44 torokati44 added the waiting-on-review Waiting on review from a Ruffle team member label Jul 28, 2024
@danielhjacobs
Copy link
Contributor

While it's fixed for now, runner-images will create a PR for a new image within the day. I want to see what Edge version and Edgedriver version it uses and see if that version has a Linux release yet.

@torokati44
Copy link
Member Author

There's still a tiny mismatch:

Microsoft Edge 127.0.2651.74
Microsoft Edge WebDriver 127.0.2651.72

@danielhjacobs
Copy link
Contributor

Yeah, and that will cause an issue:

https://msedgedriver.azureedge.net/127.0.2651.74/edgedriver_linux64.zip does not exist.

@danielhjacobs
Copy link
Contributor

See also: webdriverio/webdriverio#13251

I now have issues open with all the relevant parties, so we'll see if any are willing to fix this.

@danielhjacobs danielhjacobs force-pushed the revert-17253-danielhjacobs-patch-2 branch from a4bf857 to 3ed7701 Compare August 2, 2024 19:44
@torokati44 torokati44 force-pushed the revert-17253-danielhjacobs-patch-2 branch from 3ed7701 to 472b874 Compare August 4, 2024 07:47
@torokati44
Copy link
Member Author

This was included in #17378.

@danielhjacobs danielhjacobs deleted the revert-17253-danielhjacobs-patch-2 branch August 5, 2024 21:36
@evilpie evilpie removed the waiting-on-review Waiting on review from a Ruffle team member label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants