avm2: Limited XML namespace support #12540
Conversation
|
This almost passes I need to figure out how to run all skipped tests and find out new failing and passing tests. |
evilpie
force-pushed
the
xml-namespace
branch
2 times, most recently
from
dd5990b to
1b9613d
Compare
Uh, don't we have a magic command for that? |
It's automatic, if any test suddenly starts working it'll come up as "failing" and tell you to remove the No new tests pass because of this PR, sorry! |
|
This also makes Neopets Lost City Lanes playable! |
|
Good to know that we still make sure "failing" tests don't suddenly start working. What I actually meant was that I would be interested in basically the individual changes inside a test. For example for |
Ah okay. No easy bulk way right just, just run the swf in ruffle desktop and see what it says! |
evilpie
force-pushed
the
xml-namespace
branch
3 times, most recently
from
b9cf0df to
a1acada
Compare
| activation.context.gc_context, | ||
| ns.into_inner(), | ||
| )), | ||
| ResolveResult::Unknown(ns) => { |
There was a problem hiding this comment.
Should this have the xml and xmlns cases as well?
There was a problem hiding this comment.
I am not sure if <xmlns:dummy/> is even valid XML, because xmlns: is used as an attribute usually, but when correctly binding the namespace like this it already works: <x xmlns:xmlns="http://example.org"><xmlns:a></xmlns:a></x>.
Interestingly Flash might have a bug related to xml:. <xml:a /> works, but <xml:a></xml:a> throws
The element type "a" must be terminated by the matching end-tag "</a>".
<xml:a></a> works! 🤯
There was a problem hiding this comment.
So I added default support for xml, but not xmlns, prefixes for elements. (Matching Flash)
<xml:a />
no error
<xmlns:a />
TypeError: Error #1083: The prefix "xmlns" for element "a" is not bound.
<root xmlns:xmlns="http://example.org"><xmlns:a /></root>
no error
This fixes #10293 and #10639.
Probably also needs some manual testing to make sure we aren't regressing games that use XML and currently work.