Skip to content

RUE-1476: cache the dotslash buck2 download in the jobs that missed it #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DorianListens merged 1 commit into from
Aug 12, 2026
Merged

RUE-1476: cache the dotslash buck2 download in the jobs that missed it #2328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/cache-probe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,17 @@ jobs:
- name: Install dotslash
uses: facebook/install-dotslash@v2

# The buck2 binary itself, not build artifacts: this job deliberately
# clears buck-out and rebuilds cold, but re-downloading buck2 from the
# releases CDN is a network dependency the probe does not exist to test.
- name: Cache dotslash artifacts
uses: actions/cache@v5
with:
path: ~/.cache/dotslash
key: dotslash-linux-x64-${{ hashFiles('buck2') }}
restore-keys: |
dotslash-linux-x64-

- name: Guard — secret present
env:
KEY: ${{ secrets.BUILDBUDDY_API_KEY }}
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@ jobs:
- name: Install dotslash
uses: facebook/install-dotslash@v2 # pinned: the moving `latest` branch broke macOS runners (sha256sum flags) on 2026-06-18

# Cache the dotslash-downloaded buck2 binary (see the `test` job for the
# rationale on which paths are worth caching).
- name: Cache dotslash artifacts
uses: actions/cache@v5
with:
path: |
~/.cache/dotslash
~/Library/Caches/dotslash
key: dotslash-linux-x64-${{ hashFiles('buck2') }}
restore-keys: |
dotslash-linux-x64-

- name: Check formatting
# Every crate emits its own `<name>-fmt-check` test from the
# rue_crate/rue_binary macros (RUE-1153), so coverage follows the
Expand Down Expand Up @@ -148,6 +160,18 @@ jobs:
- name: Install dotslash
uses: facebook/install-dotslash@v2

# Cache the dotslash-downloaded buck2 binary (see the `test` job for the
# rationale on which paths are worth caching).
- name: Cache dotslash artifacts
uses: actions/cache@v5
with:
path: |
~/.cache/dotslash
~/Library/Caches/dotslash
key: dotslash-linux-x64-${{ hashFiles('buck2') }}
restore-keys: |
dotslash-linux-x64-

- name: Require and provision remote execution
env:
BUILDBUDDY_API_KEY: ${{ secrets.BUILDBUDDY_API_KEY }}
Expand Down