Repository navigation
test(workbook): qualify numeric condition precision - #1
Open
rudycelekli wants to merge 2 commits into
Open
rudycelekli wants to merge 2 commits into
rudycelekli wants to merge 2 commits into
Conversation
Freeze exact public condition evaluation using original positive and negative integer and fractional operands. Preserve ordinary numeric equivalence, exponent notation, leading zeros and string comparison controls. Production and CI are unchanged; no provider requests or credentials are required. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Compare finite numeric condition operands as exact decimals while preserving existing nonfinite numeric and lexical fallback behavior. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
rudycelekli
marked this pull request as ready for review
October 10, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests-only native qualification
Freeze the real public workbook
evaluate_conditionboundary using26 independently named cases: adjacent positive/negative large integers, fractional distinctions, native integer row inputs, and ordinary numeric/text controls. Every production file, existing test and upstream CI job is unchanged.At canonical accepted main
48aacfd44946bcf20201b58d989c0fe07cc40c09, the full upstream PR-check run37805251465 passed. In-memory source screening predicts14 incorrect comparisons and12 passing controls; that is not native test proof. This draft requests the unchanged hosted Python3.13/uv frozen backend and existing Postgres/frontend/browser gates. No provider requests, account credentials or live service tests are introduced.No production fix is committed or qualified yet. Original
tests/test_workbook_conditions.pyremains unchanged.Current production qualification
Signed source head
cebd09eacc50e58861f4302f3ec9f737f8576b6dapplies the reviewed finite Decimal comparison; frozen26 tests and original condition tests/CI unchanged. Native BEFORE37826482020:14 unique precision assertion failures,2104 passed,134 skipped,3 deselected; accepted-main baseline2092 passed with same skips/deselection establishes12 control passes by count difference. Frontend/build/browser/Postgres jobs passed. Current unchanged full AFTER run37829181897 is queued; no AFTER pass or upstream publication claimed.