Sat public review Command A (Zal 3) #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 3, 2021 12:22
onetakeone
reviewed
Apr 6, 2021
| sets = towers.map do |tower| | ||
| result = [] | ||
| column = Array.new(@tower_size, " ") | ||
| column.each_index do |i| |
There was a problem hiding this comment.
each_with_object method might be used in cases you want to fill new Array/Hash by iterating some data,
| result[i] = tower[i] | ||
| else | ||
| result[i] = column[i] | ||
| end |
There was a problem hiding this comment.
Nice practice to use oneliners like result[i] = tower[i] ? tower[i] : column[i]
| @@ -0,0 +1,6 @@ | |||
| require_relative './towers_of_hanoi' | |||
|
|
|||
| if __FILE__ == $PROGRAM_NAME | |||
There was a problem hiding this comment.
As I remember we agreed that this checkup would be excessive
| end | ||
| @towers = @towers.map{|column| column.reject{|x| x == " "} } | ||
| @sets | ||
| self.towers = towers.map{|column| column.reject{|x| x == " "} } |
There was a problem hiding this comment.
In case of a real project with larger classes and significant amount of variables and methods self.towers = towers might look confusing. In future try to find more clear way of assignment )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.