Skip to content

Update to node 22.13.1 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Update to node 22.13.1 #64

merged 4 commits into from
Jan 30, 2025

Conversation

bnoordhuis
Copy link
Collaborator

No description provided.

@bnoordhuis
Copy link
Collaborator Author

https://github.com/rubyjs/libv8-node/actions/runs/12958826686/job/36154887058?pr=64#logs

compiling ../../../../ext/mini_racer_extension/mini_racer_v8.cc
g++: internal compiler error: Segmentation fault signal terminated program cc1plus
Please submit a full bug report, with preprocessed source (by using -freport-bug).

🤦

@bnoordhuis
Copy link
Collaborator Author

Upgrading to macos-14 sort of worked but now it fails like this on the darwin x86_64 buildbot:

make[2]: *** No rule to make target /Users/runner/work/libv8-node/libv8-node/test/gtest/../../vendor/v8/arm64-darwin/libv8/obj/libv8_monolith.a', needed by c_v8_tests'. Stop.

Note the arm64-darwin in there and that's because...

Image: macos-14-arm64

There are Intel macos14 images, but only -large (i.e. paid.)

Let's see if downgrading to macos-13 works. Only a temporary solution, of course.

@bnoordhuis bnoordhuis merged commit f805e37 into rubyjs:node-22 Jan 30, 2025
24 checks passed
@bnoordhuis bnoordhuis deleted the update branch January 30, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant