-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Japanese translation #5272
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5272 +/- ##
==========================================
- Coverage 97.13% 94.36% -2.77%
==========================================
Files 457 457
Lines 9567 9626 +59
==========================================
- Hits 9293 9084 -209
- Misses 274 542 +268 ☔ View full report in Codecov by Sentry. |
Thank you for all these updates. Do you feel this is ready for review or are there more changes you would like to make? Should we have someone else check your work? My preference is for merging quickly and then applying fixes quickly but I would also appreciate a Japanese language review if possible. |
Sorry for the delay. Now it is ready for review (I made some changes to the draft.)
I agree with your approach of merging quickly and then applying fixes quickly. |
Hello RubyGems,
This updates Japanese translation (continuation of #4779).
Each commit adds changes corresponding to those made to the respective English/Japanese file (
en.yml
/ja.yml
), as specified in the commit subject.Thank you,
gemmaro.
TODOs to be ready for review.